Skip to content

Update to swagger-parser to 2.0.14-OpenAPITools.org-1 #3737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmini merged 4 commits into from
Aug 24, 2019
Merged

Update to swagger-parser to 2.0.14-OpenAPITools.org-1 #3737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a039433
Update to swagger-parser to 2.0.14-OpenAPITools.org-1
jmini Aug 23, 2019
30dcaf0
Update to released version: 2.0.14-OpenAPITools.org-1
jmini Aug 23, 2019
59360c8
Update samples
jmini Aug 23, 2019
f3c1c56
Merge remote-tracking branch 'origin/master' into update-swagger-pars…
jmini Aug 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1395,8 +1395,8 @@
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
<swagger-parser-groupid>org.openapitools.swagger.parser</swagger-parser-groupid>
<swagger-parser-version>2.0.13-OpenAPITools.org-2</swagger-parser-version>
<swagger-core-version>2.0.8</swagger-core-version>
<swagger-core-version>2.0.9</swagger-core-version>
<swagger-parser-version>2.0.14-OpenAPITools.org-1</swagger-parser-version>
<scala-version>2.11.1</scala-version>
<felix-version>3.3.1</felix-version>
<commons-io-version>2.4</commons-io-version>
Expand Down
1 change: 1 addition & 0 deletions samples/client/petstore/go/go-petstore-withXml/api/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,6 +791,7 @@ paths:
properties:
integer:
description: None
format: int32
Copy link
Member

@JFCote JFCote Aug 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these changes are related to the PR?

Copy link
Member

@JFCote JFCote Aug 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see you updated the samples, nevermind then!

Copy link
Member Author

@jmini jmini Aug 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess either Swagger-Parser is setting those (explicit default), or Swagger-Core has a new behavior.

IMO this is an acceptable change.

maximum: 100
minimum: 10
type: integer
Expand Down
1 change: 1 addition & 0 deletions samples/client/petstore/go/go-petstore/api/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,6 +791,7 @@ paths:
properties:
integer:
description: None
format: int32
maximum: 100
minimum: 10
type: integer
Expand Down
1 change: 1 addition & 0 deletions samples/client/petstore/haskell-http-client/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,6 +791,7 @@ paths:
properties:
integer:
description: None
format: int32
maximum: 100
minimum: 10
type: integer
Expand Down
1 change: 1 addition & 0 deletions samples/server/petstore/jaxrs-spec-interface/src/main/openapi/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,6 +875,7 @@ paths:
properties:
integer:
description: None
format: int32
maximum: 100
minimum: 10
type: integer
Expand Down
1 change: 1 addition & 0 deletions samples/server/petstore/jaxrs-spec/src/main/openapi/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,6 +875,7 @@ paths:
properties:
integer:
description: None
format: int32
maximum: 100
minimum: 10
type: integer
Expand Down
1 change: 1 addition & 0 deletions ...store/rust-server/output/petstore-with-fake-endpoints-models-for-testing/api/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,6 +726,7 @@ paths:
properties:
integer:
description: None
format: int32
Copy link
Member

@wing328 wing328 Aug 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI. Our petstore (fake) spec does not specify the format. I think swagger parser now defaults format to int32 for integer type if no format is specified.

Not sure if the community welcomes this change. We'll see.

maximum: 100
minimum: 10
type: integer
Expand Down
1 change: 1 addition & 0 deletions samples/server/petstore/springboot-reactive/src/main/resources/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,6 +875,7 @@ paths:
properties:
integer:
description: None
format: int32
maximum: 100
minimum: 10
type: integer
Expand Down