Skip to content

typescript-node: Use HttpError class when rejecting promises #3876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macjohnny merged 3 commits into from Sep 12, 2019
Merged

typescript-node: Use HttpError class when rejecting promises #3876

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bb71d2
Use HttpError class when rejecting promises
simhnna Sep 11, 2019
d28a320
Update samples
simhnna Sep 12, 2019
4c20449
Test the new code in client.ts
simhnna Sep 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Test the new code in client.ts
  • Loading branch information
@simhnna
simhnna committed Sep 12, 2019
commit 4c2044964fb4892a4bfafc7239f82754aea3054f
13 changes: 12 additions & 1 deletion samples/client/petstore/typescript-node/npm/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,5 +155,16 @@ petApi.addPet(pet)
})
.then((res) => {
console.log('Deleted pet');
process.exit(exitCode);
// process.exit(exitCode);
petApi.deletePet(petId).then((res) => {
throw new Error('Unexpected success');
}).catch((e) => {
if (e instanceof Error && e.name === 'HttpError' && e.message === 'HTTP request failed') {
console.log('Throws Http Errors correctly');
process.exit(exitCode);
} else {
throw new Error(`Throws unexpected error:\n ${e}`);
}
});
// process.exit(exitCode);
});