Skip to content

[Java][Client][Feign] fix a bug when encoding query parameters using a parameter map #3948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 3 commits into from
Sep 27, 2019
Merged

[Java][Client][Feign] fix a bug when encoding query parameters using a parameter map #3948

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb60aab
fixed Feign template
davide-maestroni Sep 24, 2019
2272445
regenerated Feign example
davide-maestroni Sep 24, 2019
70c7580
update java feign petstore sample
wing328 Sep 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fixed Feign template
  • Loading branch information
@davide-maestroni
davide-maestroni committed Sep 24, 2019
commit eb60aabd0bb7d5ce00c4ad4916ea3e9eeb0ab648
2 changes: 1 addition & 1 deletion modules/openapi-generator/src/main/resources/Java/libraries/feign/EncodingUtils.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public final class EncodingUtils {
return null;
}
try {
return URLEncoder.encode(parameter.toString(), "UTF-8");
return URLEncoder.encode(parameter.toString(), "UTF-8").replaceAll("\\+", "%20");
} catch (UnsupportedEncodingException e) {
// Should never happen, UTF-8 is always supported
throw new RuntimeException(e);
Expand Down