Add deprecated annotation in kotlin-spring #5090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Related issue: #3358 |
jimschubert
approved these changes
Jan 24, 2020
Member
jimschubert
left a comment
jimschubert
left a comment
There was a problem hiding this comment.
Looks great. Small question about the empty message in the annotation.
modules/openapi-generator/src/main/resources/kotlin-spring/dataClassOptVar.mustache
Show resolved
Hide resolved
ackintosh
approved these changes
Jan 27, 2020
Contributor
ackintosh
left a comment
ackintosh
left a comment
There was a problem hiding this comment.
Thanks for the PR! I've left a small comment. Please have a look when you have time. 😃
modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@jimschubert @ackintosh Thanks for reviewing. |
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to embed
@Deprecatedannotation whendeprecated: truein kotlin-springPR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu
@ackintosh