Skip to content

[go-experimental] Fix nullable support #5414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 8 commits into from
Mar 24, 2020
Merged

[go-experimental] Fix nullable support #5414

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cd51181
Fix nullable support in go-experimental client
Feb 21, 2020
6660e34
Fix support for models with parents and container fields
Feb 24, 2020
89c6693
Make sure that oneOf interfaces serialize properly even if they're re…
Feb 24, 2020
a214508
Spaces => tabs
Mar 17, 2020
69b5cf0
Regenerate samples
Mar 17, 2020
711acec
Make some methods of nullables pointer-receivers, add tests
Mar 19, 2020
abed677
Improve the Get/Set logic to make usage more convenient
Mar 19, 2020
afc8426
Address review
Mar 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions ...nerator/src/main/java/org/openapitools/codegen/languages/GoClientExperimentalCodegen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,11 @@ public CodegenProperty fromProperty(String name, Schema p) {

@Override
public Map<String, Object> postProcessModels(Map<String, Object> objs) {
// The superclass determines the list of required golang imports. The actual list of imports
// depends on which types are used, some of which are changed in the code below (but then preserved
// and used through x-basetype in templates). So super.postProcessModels
// must be invoked at the beginning of this method.
objs = super.postProcessModels(objs);

List<Map<String, Object>> models = (List<Map<String, Object>>) objs.get("models");
for (Map<String, Object> m : models) {
Expand All @@ -162,6 +167,7 @@ public Map<String, Object> postProcessModels(Map<String, Object> objs) {
}

for (CodegenProperty param : model.vars) {
param.vendorExtensions.put("x-basetype", param.dataType);
if (!param.isNullable || param.isMapContainer || param.isListContainer) {
continue;
}
Expand All @@ -178,11 +184,6 @@ public Map<String, Object> postProcessModels(Map<String, Object> objs) {
}
}
}

// The superclass determines the list of required golang imports. The actual list of imports
// depends on which types are used, which is done in the code above. So super.postProcessModels
// must be invoked at the end of this method.
objs = super.postProcessModels(objs);
return objs;
}

Expand Down
Loading