Skip to content

[Python-experimental] Documentation enhancement for oneOf schema and minor err msg improvement #5791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spacether merged 12 commits into from
Apr 4, 2020
Merged

[Python-experimental] Documentation enhancement for oneOf schema and minor err msg improvement #5791

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ffedf9e
Add documentation to generated code
sebastien-rosset Apr 1, 2020
2ac9771
Improve error message
sebastien-rosset Apr 1, 2020
e73a2cd
Improve documentation
sebastien-rosset Apr 1, 2020
e2ba725
Improve documentation
sebastien-rosset Apr 1, 2020
f1b7a50
Improve documentation
sebastien-rosset Apr 1, 2020
0dfdd74
Improve documentation
sebastien-rosset Apr 1, 2020
a531931
Improve documentation
sebastien-rosset Apr 1, 2020
19c884f
Improve documentation
sebastien-rosset Apr 1, 2020
f56e18a
Run sample scripts
sebastien-rosset Apr 1, 2020
030f2dd
Address review comments
sebastien-rosset Apr 3, 2020
16cbb88
Address review comments
sebastien-rosset Apr 3, 2020
b2920c1
Fix problem in python error message
sebastien-rosset Apr 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve documentation
  • Loading branch information
@sebastien-rosset
sebastien-rosset committed Apr 1, 2020
commit f1b7a509e4f741bc5e6dba9e087c68d6c8d536e8
4 changes: 3 additions & 1 deletion modules/openapi-generator/src/main/resources/python/python-experimental/model_utils.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,8 +965,10 @@ def get_oneof_instance(self, model_args, constant_args):
return None

oneof_instances = []
# Iterate over each oneOf schema and determine if the input data
# matches the oneOf schemas.
for oneof_class in self._composed_schemas()['oneOf']:
# transform js keys to python keys in fixed_model_args
# transform js keys from input data to python keys in fixed_model_args
fixed_model_args = change_keys_js_to_python(
model_args, oneof_class)

Expand Down