Skip to content

[Python-experimental] Use DER encoding for ECDSA signatures, add parameter to configure hash algorithm #5924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spacether merged 8 commits into from
Apr 15, 2020
Merged

[Python-experimental] Use DER encoding for ECDSA signatures, add parameter to configure hash algorithm #5924

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3ba14ec
Use DER encoding for ECDSA signatures
sebastien-rosset Apr 14, 2020
5df82b8
Use DER encoding for ECDSA signatures
sebastien-rosset Apr 14, 2020
23e2810
Use DER encoding for ECDSA signatures
sebastien-rosset Apr 14, 2020
978df01
Use DER encoding for ECDSA signatures
sebastien-rosset Apr 14, 2020
c7c8ef4
fix python unit tests for http message signature
sebastien-rosset Apr 14, 2020
6cbc24a
Fix error message
sebastien-rosset Apr 15, 2020
d22990f
format python code
sebastien-rosset Apr 15, 2020
a7bd6ba
format python code
sebastien-rosset Apr 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use DER encoding for ECDSA signatures
  • Loading branch information
@sebastien-rosset
sebastien-rosset committed Apr 14, 2020
commit 3ba14ec410db398c0acc87c9ac81a2cbf6705c57
4 changes: 3 additions & 1 deletion modules/openapi-generator/src/main/resources/python/python-experimental/signing.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,9 @@ class HttpSigningConfiguration(object):
if sig_alg is None:
sig_alg = ALGORITHM_ECDSA_MODE_FIPS_186_3
if sig_alg in ALGORITHM_ECDSA_KEY_SIGNING_ALGORITHMS:
signature = DSS.new(self.private_key, sig_alg).sign(digest)
# draft-ietf-httpbis-message-signatures-00 does not specify the ECDSA encoding.
# Issue: https://github.com/w3c-ccg/http-signatures/issues/107
signature = DSS.new(key=self.private_key, mode=sig_alg, encoding='der').sign(digest)
else:
raise Exception("Unsupported signature algorithm: {0}".format(sig_alg))
else:
Expand Down
4 changes: 3 additions & 1 deletion samples/openapi3/client/petstore/python-experimental/petstore_api/signing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,9 @@ def _sign_digest(self, digest):
if sig_alg is None:
sig_alg = ALGORITHM_ECDSA_MODE_FIPS_186_3
if sig_alg in ALGORITHM_ECDSA_KEY_SIGNING_ALGORITHMS:
signature = DSS.new(self.private_key, sig_alg).sign(digest)
# draft-ietf-httpbis-message-signatures-00 does not specify the ECDSA encoding.
# Issue: https://github.com/w3c-ccg/http-signatures/issues/107
signature = DSS.new(key=self.private_key, mode=sig_alg, encoding='der').sign(digest)
else:
raise Exception("Unsupported signature algorithm: {0}".format(sig_alg))
else:
Expand Down