Skip to content

[python-experimental] Minor doc update, code comments and exception handling #5945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spacether merged 7 commits into from
Apr 24, 2020
Merged

[python-experimental] Minor doc update, code comments and exception handling #5945

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4e1dba5
add support for any type, i.e. when 'type' attribute is not specified…
sebastien-rosset Apr 15, 2020
7fb2602
fix typos, add code comments
sebastien-rosset Apr 16, 2020
78f71ba
Handle case when 'type' attribute is not present in the OAS schema
sebastien-rosset Apr 16, 2020
43eecab
fix python formatting rule
sebastien-rosset Apr 18, 2020
332d5f5
fix python formatting rule
sebastien-rosset Apr 18, 2020
bc46963
remove 'object' as a type
sebastien-rosset Apr 23, 2020
025d87d
Merge branch 'master' of github.com:CiscoM31/openapi-generator into p…
sebastien-rosset Apr 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add support for any type, i.e. when 'type' attribute is not specified… 
… in OAS schema
  • Loading branch information
@sebastien-rosset
sebastien-rosset committed Apr 15, 2020
commit 4e1dba5012df6ebf70c1f7f87c10569e764089b3
5 changes: 4 additions & 1 deletion modules/openapi-generator/src/main/resources/python/python-experimental/model_utils.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ COERCION_INDEX_BY_TYPE = {
date: 10,
str: 11,
file_type: 12,
object: 13, # Any type, i.e. 'type' is not specified in the OAS schema.
}

# these are used to limit what type conversions we try to do
Expand Down Expand Up @@ -373,7 +374,9 @@ def order_response_types(required_types):
elif (inspect.isclass(class_or_instance)
and issubclass(class_or_instance, ModelSimple)):
return COERCION_INDEX_BY_TYPE[ModelSimple]
return COERCION_INDEX_BY_TYPE[class_or_instance]
if class_or_instance in COERCION_INDEX_BY_TYPE:
return COERCION_INDEX_BY_TYPE[class_or_instance]
raise ApiValueError("Unsupported type: %s" % class_or_instance)

sorted_types = sorted(
required_types,
Expand Down
5 changes: 4 additions & 1 deletion samples/client/petstore/python-experimental/petstore_api/model_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,7 @@ def __eq__(self, other):
date: 10,
str: 11,
file_type: 12,
object: 13, # Any type, i.e. 'type' is not specified in the OAS schema.
}

# these are used to limit what type conversions we try to do
Expand Down Expand Up @@ -629,7 +630,9 @@ def index_getter(class_or_instance):
elif (inspect.isclass(class_or_instance)
and issubclass(class_or_instance, ModelSimple)):
return COERCION_INDEX_BY_TYPE[ModelSimple]
return COERCION_INDEX_BY_TYPE[class_or_instance]
if class_or_instance in COERCION_INDEX_BY_TYPE:
return COERCION_INDEX_BY_TYPE[class_or_instance]
raise ApiValueError("Unsupported type: %s" % class_or_instance)

sorted_types = sorted(
required_types,
Expand Down
5 changes: 4 additions & 1 deletion samples/openapi3/client/petstore/python-experimental/petstore_api/model_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,7 @@ def __eq__(self, other):
date: 10,
str: 11,
file_type: 12,
object: 13, # Any type, i.e. 'type' is not specified in the OAS schema.
}

# these are used to limit what type conversions we try to do
Expand Down Expand Up @@ -629,7 +630,9 @@ def index_getter(class_or_instance):
elif (inspect.isclass(class_or_instance)
and issubclass(class_or_instance, ModelSimple)):
return COERCION_INDEX_BY_TYPE[ModelSimple]
return COERCION_INDEX_BY_TYPE[class_or_instance]
if class_or_instance in COERCION_INDEX_BY_TYPE:
return COERCION_INDEX_BY_TYPE[class_or_instance]
raise ApiValueError("Unsupported type: %s" % class_or_instance)

sorted_types = sorted(
required_types,
Expand Down