Skip to content

Propagate deprecated property through $ref's #6093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 2 commits into from
May 1, 2020
Merged

Propagate deprecated property through $ref's #6093

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
867d47d
Propagate deprecated property through $ref's
asmundg Apr 28, 2020
6e716f4
Clarify why we're messing around with $ref
asmundg Apr 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Clarify why we're messing around with $ref
  • Loading branch information
@asmundg
asmundg committed Apr 29, 2020
commit 6e716f49053b17485c97f9589f7d93232b36f23f
3 changes: 3 additions & 0 deletions modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2845,6 +2845,9 @@ public CodegenProperty fromProperty(String name, Schema p) {
if (p.getDeprecated() != null) {
property.deprecated = p.getDeprecated();
} else if (p.get$ref() != null) {
// Since $ref should be replaced with the model it refers
// to, $ref'ing a model with 'deprecated' set should cause
// the property to reflect the model's 'deprecated' value.
String ref = ModelUtils.getSimpleRef(p.get$ref());
if (ref != null) {
Schema referencedSchema = ModelUtils.getSchemas(this.openAPI).get(ref);
Expand Down