Skip to content

[C++][Pistache] Catch HttpError from user-provided handler #6520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etherealjoy merged 2 commits into from
Jun 5, 2020
Merged

[C++][Pistache] Catch HttpError from user-provided handler #6520

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8ff68d
[C++][Pistache] Catch HttpError when user-provided handler has thrown
muttleyxd Jun 2, 2020
a6484db
[C++][Pistache] Update Petstore sample
muttleyxd Jun 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[C++][Pistache] Catch HttpError when user-provided handler has thrown 
This allows for returning valid http code through exception
  • Loading branch information
@muttleyxd
muttleyxd committed Jun 2, 2020
commit a8ff68dfb6cb77054cae0e672f796c61303f7057
3 changes: 3 additions & 0 deletions modules/openapi-generator/src/main/resources/cpp-pistache-server/api-source.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ void {{classname}}::{{operationIdSnakeCase}}_handler(const Pistache::Rest::Reque
//send a 400 error
response.send(Pistache::Http::Code::Bad_Request, e.what());
return;
} catch (Pistache::Http::HttpError &e) {
response.send(static_cast<Pistache::Http::Code>(e.code()), e.what());
return;
} catch (std::exception &e) {
//send a 500 error
response.send(Pistache::Http::Code::Internal_Server_Error, e.what());
Expand Down