Skip to content

Conversation

@sa9sha9
Copy link
Contributor

@sa9sha9 sa9sha9 commented Jun 10, 2020

Description of the PR

Related issues: fixes #6289
Similar PRs: #4110, #4540 for typescript-fetch

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
    • Run bin/typescript-axios-petstore-all.sh for re-generating samples.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny macjohnny merged commit 9fdcbec into OpenAPITools:master Jun 10, 2020
@macjohnny macjohnny added this to the 5.0.0 milestone Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQ] Add eslint-disable block comment to typescript-axios generated files

2 participants