Skip to content

[Slim] Add PHPLint tool to check syntax #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ybelenko merged 3 commits into from
Aug 26, 2018
Merged

[Slim] Add PHPLint tool to check syntax #898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f11bbcd
[Slim] Add phplint package to dependencies
ybelenko Aug 26, 2018
ef1f14a
[Slim] Update main doc
ybelenko Aug 26, 2018
bbd7ca4
[Slim] Refresh samples
ybelenko Aug 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/openapi-generator/src/main/resources/php-slim-server/README.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
## Requirements

* Web server with URL rewriting
* PHP 5.5 or newer
* PHP 5.5.9 or newer

This package contains `.htaccess` for Apache configuration.
If you use another server(Nginx, HHVM, IIS, lighttpd) check out [Web Servers](https://www.slimframework.com/docs/v3/start/web-servers.html) doc.
Expand Down Expand Up @@ -33,12 +33,14 @@ $ php -S localhost:8888 -t php-slim-server
This package uses PHPUnit 4.8 for unit testing.
[Test folder]({{testBasePath}}) contains templates which you can fill with real test assertions.
How to write tests read at [PHPUnit Manual - Chapter 2. Writing Tests for PHPUnit](https://phpunit.de/manual/4.8/en/writing-tests-for-phpunit.html).
There is [phplint](https://github.com/overtrue/phplint) tool to check php syntax automatically.

Command | Tool | Target
---- | ---- | ----
`$ composer test` | PHPUnit | All tests
`$ composer run test-apis` | PHPUnit | Apis tests
`$ composer run test-models` | PHPUnit | Models tests
`$ composer run phplint` | phplint | All files

{{#generateApiDocs}}
## API Endpoints
Expand Down
8 changes: 5 additions & 3 deletions modules/openapi-generator/src/main/resources/php-slim-server/composer.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
{
"minimum-stability": "RC",
"require": {
"php": ">=5.5",
"php": ">=5.5.9",
"slim/slim": "3.*",
"tuupola/slim-basic-auth": "^3.0.0"
},
"require-dev": {
"phpunit/phpunit": "^4.8"
"phpunit/phpunit": "^4.8",
"overtrue/phplint": "^1.0"
},
"autoload": {
"psr-4": { "{{escapedInvokerPackage}}\\": "{{srcBasePath}}/" }
Expand All @@ -20,6 +21,7 @@
"@test-models"
],
"test-apis": "phpunit --testsuite Apis",
"test-models": "phpunit --testsuite Models"
"test-models": "phpunit --testsuite Models",
"phplint": "phplint ./ --exclude=vendor"
}
}
4 changes: 3 additions & 1 deletion samples/server/petstore-security-test/php-slim/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
## Requirements

* Web server with URL rewriting
* PHP 5.5 or newer
* PHP 5.5.9 or newer

This package contains `.htaccess` for Apache configuration.
If you use another server(Nginx, HHVM, IIS, lighttpd) check out [Web Servers](https://www.slimframework.com/docs/v3/start/web-servers.html) doc.
Expand Down Expand Up @@ -33,12 +33,14 @@ $ php -S localhost:8888 -t php-slim-server
This package uses PHPUnit 4.8 for unit testing.
[Test folder](test) contains templates which you can fill with real test assertions.
How to write tests read at [PHPUnit Manual - Chapter 2. Writing Tests for PHPUnit](https://phpunit.de/manual/4.8/en/writing-tests-for-phpunit.html).
There is [phplint](https://github.com/overtrue/phplint) tool to check php syntax automatically.

Command | Tool | Target
---- | ---- | ----
`$ composer test` | PHPUnit | All tests
`$ composer run test-apis` | PHPUnit | Apis tests
`$ composer run test-models` | PHPUnit | Models tests
`$ composer run phplint` | phplint | All files

## API Endpoints

Expand Down
8 changes: 5 additions & 3 deletions samples/server/petstore-security-test/php-slim/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
{
"minimum-stability": "RC",
"require": {
"php": ">=5.5",
"php": ">=5.5.9",
"slim/slim": "3.*",
"tuupola/slim-basic-auth": "^3.0.0"
},
"require-dev": {
"phpunit/phpunit": "^4.8"
"phpunit/phpunit": "^4.8",
"overtrue/phplint": "^1.0"
},
"autoload": {
"psr-4": { "OpenAPIServer\\": "lib/" }
Expand All @@ -20,6 +21,7 @@
"@test-models"
],
"test-apis": "phpunit --testsuite Apis",
"test-models": "phpunit --testsuite Models"
"test-models": "phpunit --testsuite Models",
"phplint": "phplint ./ --exclude=vendor"
}
}
Loading