Skip to content

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Aug 30, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

To prepare the 3.2.3 release

@wing328 wing328 added this to the 3.2.3 milestone Aug 30, 2018
@cbornet cbornet self-requested a review August 30, 2018 09:43
@jmini
Copy link
Member

jmini commented Aug 30, 2018

About a6191ea: If you would regenerate the samples/meta-codegen content with bin/meta-codegen.sh, then you would have the same result.

But we are not generating our samples when we perform the release, so the solution of using bin/utils/release_version_update.sh the version is OK for me.

@wing328 wing328 merged commit 5745f6d into master Aug 30, 2018
@wing328 wing328 deleted the 3.2.3-release branch August 30, 2018 11:08
@jmini
Copy link
Member

jmini commented Aug 30, 2018

@jmini
Copy link
Member

jmini commented Aug 30, 2018

Result of command ruby bin/utils/release_checkout.rb 3.2.3:

Running checkout on OpenAPI Generator release 3.2.3
Checking homebrew forumla ... [ERROR]
> https://raw.githubusercontent.com/Homebrew/homebrew-core/master/Formula/openapi-generator.rb not yet updated with https://search.maven.org/remotecontent?filepath=org/openapitools/openapi-generator-cli/3.2.3/openapi-generator-cli-3.2.3.jar
Checking openapi-generator JAR ... [OK]
Checking openapi-generator-cli JAR ... [OK]
Checking openapi-generator-maven-plugin JAR ... [OK]
Checking openapi-generator-gradle-plugin JAR ... [ERROR]
> http://central.maven.org/maven2/org/openapitools/openapi-generator-gradle-plugin/3.2.3/openapi-generator-gradle-plugin-3.2.3.jar not found
Checking openapi-generator-online JAR ... [OK]
Checking openapi-generator-project pom.xml ... [OK]
Checking openapi-generator README.md ... [OK]
Checking openapi-generator-online docker ... [OK]
Checking openapi-generator-cli docker ... [OK]

@jmini
Copy link
Member

jmini commented Aug 30, 2018

PR #938 is merged to master. Ready to work on 3.3.0-SNAPSHOT.

@jmini
Copy link
Member

jmini commented Aug 30, 2018

Homebrew formula Homebrew/homebrew-core#31602

@jmini
Copy link
Member

jmini commented Aug 31, 2018

gradle plugin 3.2.3 is publised on sonatype releases.

https://oss.sonatype.org/content/repositories/releases/

It will appear on maven-central soon.

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* update release version, disabled ensure up to date script

* update release table

* update stable version to 3.2.3

* update samples/meta-codegen/lib/pom.xml and release_version_update.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants