This repository was archived by the owner on Nov 15, 2021. It is now read-only.
Access violation is occurred at AddVisitPointToThreadBuffer.
#330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At
AddVisitPointToThreadBuffer, there is a case thatGetVisitMapForOSThreadreturns a null reference.In
GetVisitMapForOSThread, there ism_visitmapwhich isstd::unordered_map<ULONG, MSG_SendVisitPoints_Request*>. This type's subscript operator returns the default value of the data type if the key value is not foundI think you can reproduce this issue by these sample's steps. If using version 4.5.3723, there is no problem. However, if using the latest version 4.6.166, you will encounter the access violation like the above image. Therefore, I think you should set new
MSG_SendVisitPoints_Requesttom_visitmapeven ifosThreadIDis not found 😷