Skip to content
This repository was archived by the owner on Nov 15, 2021. It is now read-only.

Conversation

@urasandesu
Copy link
Contributor

At AddVisitPointToThreadBuffer, there is a case that GetVisitMapForOSThread returns a null reference.

default

In GetVisitMapForOSThread, there is m_visitmap which is std::unordered_map<ULONG, MSG_SendVisitPoints_Request*>. This type's subscript operator returns the default value of the data type if the key value is not found

I think you can reproduce this issue by these sample's steps. If using version 4.5.3723, there is no problem. However, if using the latest version 4.6.166, you will encounter the access violation like the above image. Therefore, I think you should set new MSG_SendVisitPoints_Request to m_visitmap even if osThreadID is not found 😷

sawilde added a commit that referenced this pull request Aug 3, 2015
Access violation is occurred at `AddVisitPointToThreadBuffer`.
@sawilde sawilde merged commit 1d90a63 into OpenCover:master Aug 3, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants