Skip to content
This repository was archived by the owner on Nov 15, 2021. It is now read-only.

Conversation

@sawilde
Copy link
Member

@sawilde sawilde commented Jan 31, 2016

No description provided.

ddur and others added 30 commits January 26, 2016 17:13
Optional parameters should not be used
Reduce the number of conditional operators (8) used in the expression
(maximum allowed 3).
The cyclomatic complexity of a function should not exceed a defined
threshold (10)
The Cyclomatic Complexity of this method is 11 which is greater than 10
authorized
Merge this if statement with the enclosing one
The Cyclomatic Complexity of this method is 14 which is greater than 10
authorized
The Cyclomatic Complexity of this method is 20 which is greater than 10
authorized
Line 730 is not commented code.
Merge this if statement with the enclosing one.
SonarCube: Method Complexity & few tests added
SonarCube: Complexity grows with lines reduced :D
Change time to Utc time & fix test time
process string is named processPath in
Messages.cs
MessageHandler
IProfilerCommunication.cs

and ProfilerCommunication.cs where is transformed to processName by call
to Path.GetFileNameWithoutExtension (processPath) when calling
UseAssembly, InstrumentClass and InstrumentProcess

It is processName in
IFilter.cs, Filter.cs and AssemblyAndClassFilter.cs
@sawilde sawilde self-assigned this Jan 31, 2016
@sawilde sawilde added this to the Release (Q1 2016) milestone Jan 31, 2016
@sawilde
Copy link
Member Author

sawilde commented Jan 31, 2016

staged - waiting for coverity report later today

sawilde added a commit that referenced this pull request Feb 1, 2016
create a release-candidate
@sawilde sawilde merged commit 0f35bfa into rc Feb 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants