-
Notifications
You must be signed in to change notification settings - Fork 156
Unit test fixes #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test fixes #238
Conversation
Current coverage is 87.14% (diff: 100%)@@ master #238 diff @@
==========================================
Files 64 64
Lines 8409 8409
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7328 7328
Misses 1081 1081
Partials 0 0
|
|
The problems this pull request fixed came up when rebuilding the python-pykmip package from Ubuntu zesty (0.5.0-4) using the v0.6.0 tarball from PyPI. The Debian build uses python-coverage and not tox. |
|
I'm fine with the |
|
@PeterHamilton the mock was being applied to the kmip.services.server.server class which does not have an open method. |
|
I think the |
|
Nevermind, I'm already using |
|
See PR #239 for the open mock fix. |
|
PR #239 has been merged. Once this PR is updated, I'll merge it as well. |
Fix unittests for compatibility between Python 2 and 3.
|
Removed my changes to test_server.py because of #239. |
Fix unittests for compatibility between Python 2 and 3.
Fixed a mock for open() in kmip.services.server.server