Skip to content

Conversation

@PeterHamilton
Copy link
Contributor

This change adds request/response payloads for the DeriveKey operation, updating the payload factories to support DeriveKey. Unit tests for the payloads and payload factories are included. The inequality operator was also added to the TemplateAttribute struct to support the DeriveKey payload unit tests; differences in Python2.7 and 3+ led to comparison failures.

@codecov-io
Copy link

codecov-io commented Jun 23, 2017

Codecov Report

Merging #294 into master will increase coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #294      +/-   ##
=========================================
+ Coverage   89.41%   89.7%   +0.29%     
=========================================
  Files          63      64       +1     
  Lines        8976    9200     +224     
=========================================
+ Hits         8026    8253     +227     
+ Misses        950     947       -3
Impacted Files Coverage Δ
kmip/core/factories/payloads/request.py 100% <100%> (ø) ⬆️
kmip/core/objects.py 63.27% <100%> (+0.63%) ⬆️
kmip/core/messages/payloads/derive_key.py 100% <100%> (ø)
kmip/core/factories/payloads/response.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38ee408...344cce8. Read the comment docs.

This change adds request/response payloads for the DeriveKey
operation, updating the payload factories to support DeriveKey.
Unit tests for the payloads and payload factories are included.
The inequality operator was also added to the TemplateAttribute
struct to support the DeriveKey payload unit tests; differences
in Python2.7 and 3+ led to comparison failures.
@PeterHamilton PeterHamilton force-pushed the feat/add-derive-key-payloads branch from eaf7867 to 344cce8 Compare June 23, 2017 22:31
@PeterHamilton PeterHamilton merged commit e18dd54 into master Jun 26, 2017
@PeterHamilton PeterHamilton deleted the feat/add-derive-key-payloads branch July 11, 2017 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants