Skip to content

Conversation

@mdong
Copy link
Contributor

@mdong mdong commented Jun 24, 2016

Hi,

Most file use the macro defined in common.h, but i guess cdot.c and zdot.c missed the memo ^_^ .

Best,
Min Dong

@martin-frbg
Copy link
Collaborator

Just for the record I do not think now that this will work as is across all platforms, as in some cases the CREAL will expand to a macro or function rather than the keyword - which is illegal on the lefthand side.

@mdong mdong closed this Mar 14, 2017
@mdong mdong deleted the small_fix_for_pgi branch March 14, 2017 14:20
@martin-frbg
Copy link
Collaborator

Thank you for highlighting this problem (and eventually leading me in the right direction, I hope) all the same. It's a pity that your contribution apparently was not looked at for so long.

@mdong
Copy link
Contributor Author

mdong commented Mar 14, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants