Add configurable timeout for vLLM server initialization #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes OpenPipe#281 by making the OpenAI server startup timeout configurable via the ART_SERVER_TIMEOUT environment variable. This allows users with slower model initialization to increase the timeout from the default 10 seconds. Changes: - Add ART_SERVER_TIMEOUT environment variable support - Improve error message to inform users about the timeout option - Maintain backward compatibility with 10-second default Future work: Add environment variables documentation section to docs.
Closed
|
@geekalaa looks like the code quality checks failed. Could you run |
|
@arcticfly I’ve fixed the code quality issues using |
|
Thanks @geekalaa! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #281 by making the OpenAI server startup
timeout configurable via the ART_SERVER_TIMEOUT environment variable.
Summary
Test plan
Future work
Add environment variables documentation section to docs.