Skip to content

Adding the missing field for echo pulse width to logical detections #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2023
Merged

Adding the missing field for echo pulse width to logical detections #590

merged 1 commit into from
Mar 13, 2023

Conversation

PhRosenberger
Copy link
Contributor

@PhRosenberger PhRosenberger commented Oct 18, 2021 •
edited
Loading

This is necessary to represent Ibeo LUX ECU data or similar that contain fused lidar point clouds with echo pulse width instead of intensity.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

  • My suggestion follows the style and contributors guidelines.
  • I have taken care about the documentation.
  • I have done the DCO signoff.
  • My changes generate no errors when passing CI tests.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!

@PhRosenberger PhRosenberger added the FeatureRequest Proposals which enhance the interface or add additional features. label Oct 18, 2021
@PhRosenberger PhRosenberger force-pushed the feature/echo_pulse_width_to_logical_detection branch from 8835fb2 to 56de6eb Compare October 18, 2021 19:30
LukasElster
LukasElster approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@LukasElster LukasElster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@clemenshabedank
Copy link
Contributor

09.05.2022: @kmeids might this be a change suitable for v3.5?

@ClemensLinnhoff ClemensLinnhoff added OpenMSL Required to enable sub-libraries in OpenMSL. ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Mar 3, 2023
@pmai pmai added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Mar 13, 2023
@pmai
Copy link
Contributor

pmai commented Mar 13, 2023

CCB 2023-03-13: Merge as-is.

@pmai pmai assigned pmai and unassigned kmeids Mar 13, 2023
@PhRosenberger @pmai
Adding the missing field for echo pulse width to logical detections f…
33907ab 
…or fused lidar detections

Signed-off-by: PhRosenberger <[email protected]>
@pmai pmai force-pushed the feature/echo_pulse_width_to_logical_detection branch from 690825a to 33907ab Compare March 13, 2023 20:03
@pmai pmai merged commit 9b037cd into master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@LukasElster LukasElster LukasElster approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pmai pmai

Labels

FeatureRequest Proposals which enhance the interface or add additional features. OpenMSL Required to enable sub-libraries in OpenMSL. ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@PhRosenberger @clemenshabedank @pmai @LukasElster @kmeids @ClemensLinnhoff