Skip to content

Add more top-level messages to OSITrace #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 10, 2024
Merged

Add more top-level messages to OSITrace #818

merged 6 commits into from
Jun 10, 2024

Conversation

ClemensLinnhoff
Copy link
Contributor

@ClemensLinnhoff ClemensLinnhoff commented May 27, 2024 •
edited
Loading

Reference to a related issue in the repository

#817

Add a description

Added "TrafficUpdate", "TrafficCommand" and "TrafficCommandUpdate" as possible type inputs.
I tested locally with osi2read.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

@ClemensLinnhoff
Add three more top-level messages
27df0e4 
Signed-off-by: ClemensLinnhoff <[email protected]>
@ClemensLinnhoff ClemensLinnhoff linked an issue May 27, 2024 that may be closed by this pull request
Support more top-level messages in OSITrace #817
Closed
@ClemensLinnhoff
Formatting
8f5a8fc 
Signed-off-by: ClemensLinnhoff <[email protected]>
@ClemensLinnhoff ClemensLinnhoff marked this pull request as ready for review May 27, 2024 14:20
@ClemensLinnhoff ClemensLinnhoff mentioned this pull request May 28, 2024
Closed
@jdsika jdsika added the Bug Problems in the build system, build scripts, etc or faults in the interface. label May 28, 2024
@jdsika jdsika added this to the V3.7.1 milestone May 28, 2024
@jdsika
Copy link
Contributor

jdsika commented May 28, 2024

To be honest I think this is more a bug then a feature request and I would merge this for 3.7.0

But this should be discussed by @pmai and @PhRosenberger

@jdsika jdsika added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label May 28, 2024
@ClemensLinnhoff ClemensLinnhoff mentioned this pull request Jun 3, 2024
Merged
6 tasks
@pmai
Add remaining missing top-level interfaces and tests
91cc877 
Add all remaining top-level interfaces, fix documentation list of said
interfaces and add tests for all interfaces to the osi_trace tests.

Signed-off-by: Pierre R. Mai <[email protected]>
@pmai pmai modified the milestones: V3.7.1, V3.7.0 Jun 9, 2024
pmai
pmai reviewed Jun 10, 2024
View reviewed changes
Copy link
Contributor

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CCB 2024-06-10: Merge after addition of HostVehicleData incl. test case by @pmai.

@pmai pmai added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Jun 10, 2024
@pmai pmai merged commit 4a5f43f into master Jun 10, 2024
@pmai pmai deleted the 817-support-more-top-level-messages-in-ositrace branch June 10, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmai pmai pmai left review comments

@jdsika jdsika jdsika approved these changes

@PhRosenberger PhRosenberger PhRosenberger approved these changes

@florianwallerer florianwallerer florianwallerer approved these changes

Assignees

No one assigned

Labels

Bug Problems in the build system, build scripts, etc or faults in the interface. ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.

Projects

None yet

Milestone

V3.7.0

Development

Successfully merging this pull request may close these issues.

Support more top-level messages in OSITrace

5 participants

@ClemensLinnhoff @jdsika @pmai @PhRosenberger @florianwallerer