Skip to content

Use env variables to set SMTP settings #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2018
Merged

Use env variables to set SMTP settings #222

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f4cd11
Use env variables to set SMTP settings
jarifibrahim Jan 5, 2018
2e8da0f
Merge branch 'predev' into env-variable
tapaswenipathak Dec 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'predev' into env-variable
  • Loading branch information
@tapaswenipathak
tapaswenipathak authored Dec 16, 2018
commit 2e8da0f5fec1408c8dea4394f276d1a6d1092e9c
4 changes: 4 additions & 0 deletions oshc/oshc/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,10 @@
EMAIL_HOST_USER = os.getenv('EMAIL_ID', '')
EMAIL_HOST_PASSWORD = os.getenv('EMAIL_PASSWORD', '')
EMAIL_PORT = os.getenv('EMAIL_PORT', '')

if DEBUG:
EMAIL_BACKEND = 'django.core.mail.backends.console.EmailBackend'

EMAIL_USE_TLS = True

Copy link
Member

@tapaswenipathak tapaswenipathak Jan 6, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Register/Login is of no good use if we don't confirm the email. Currently we have it hidden on master, once we are up with check we would make it live. This is needed and cannot be removed. Did you get the chance to set it on Heroku? or does this not work for you? looks good.

Copy link
Member Author

@jarifibrahim jarifibrahim Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tapasweni-pathak There is a known issue with Gmail and Heroku. Heroku servers are located all around the world. When we try to send an email via Heroku server, Gmail blocks the request considering the unusual origin of the request. We could try and see if this works, but I'm not sure if this email verification via emails from gmail should be used on production.

Copy link
Member

@tapaswenipathak tapaswenipathak Jan 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happens with mutt too if you use it with Gmail, this needs to be set up in that case and we can restrict to heroku. Can you please drop a blog or something, as I'm aware about this but not about the known issue, thanks!

LOGIN_REDIRECT_URL = "/"
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.