Remove email related settings and disable email verification #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 5, 2018
oshc/oshc/settings.py
Outdated
| CRISPY_TEMPLATE_PACK = 'bootstrap3' | ||
|
|
||
| # Allauth settings | ||
| ACCOUNT_EMAIL_VERIFICATION = None # Disable email verification of new user |
There was a problem hiding this comment.
at least two spaces before inline comment
3 tasks
This was referenced Jan 5, 2018
jarifibrahim
force-pushed
the
remove-email
branch
from
04f0e82 to
cde9350
Compare
jarifibrahim
force-pushed
the
remove-email
branch
from
cde9350 to
3c2c8a4
Compare
| EMAIL_HOST_USER = 'email' | ||
| EMAIL_HOST_PASSWORD = 'password' | ||
| EMAIL_PORT = 587 | ||
| EMAIL_USE_TLS = True |
Member
There was a problem hiding this comment.
If you want to try please go ahead and merge to predev, we need to make sure necessary issues are open. refing #222 (review).
Member
There was a problem hiding this comment.
We also have #202, we will keep this open and I feel fine with closing the mini ones, no probs.
houndci-bot
reviewed
Dec 16, 2018
oshc/oshc/settings.py
Outdated
| EMAIL_HOST_PASSWORD = 'password' | ||
| EMAIL_PORT = 587 | ||
| EMAIL_USE_TLS = True | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not need email verification for new users right now.
Let's try to make sure basic features work well before adding optional features.
With the PR, email verification is disabled.