Vbv dev #155

dinesh0603 · 2019-03-20T12:05:22Z

Hi Amir & Hassene,

I have created PR for VBV_dev code with https://github.com/OpenVisualCloud/SVT-HEVC.

Please let me know if you are facing any issues.

Thanks & Regards,
Dinesh

…istance 2. Added Check for FrameIndex not exceding No of Frame to Encode

… the feedback of the previous base layer has arrived. The impact on speed to be evaluated

…r than or equal to the TemporalId of the access unit containing the NAL unit

This fix ensures right signalling of Picture timing for keyframes>0

…usly It was going beyond target Bitrate and was within Max Bitrate, if Max rate is Greater than Target Bitrate

… Entry

…trol

tianjunwork · 2019-04-23T20:55:14Z

Source/App/EbAppConfig.c

-static void SetVbvBufsize                       (const char *value, EbConfig_t *cfg) { cfg->vbvBufsize = strtoul(value, NULL, 0); };
-static void SetVbvBufInit                       (const char *value, EbConfig_t *cfg) { cfg->vbvBufInit = strtoul(value, NULL, 0); };
-static void SetHrdFlag                          (const char *value, EbConfig_t *cfg) { cfg->hrdFlag = strtoul(value, NULL, 0); };
+static void SetVbvMaxrate                       (const char *value, EbConfig_t *cfg) { cfg->vbvMaxRate						= strtoul(value, NULL, 0); };


please remove the necessary space here.

Modified code as per review comments and pushed patch (Commit : 9db1593)

tianjunwork · 2019-04-23T20:57:33Z

Source/API/EbApi.h

    // VBV Parameters
-
+	/* Sets the maximum rate the VBV buffer should be assumed to refill at
+		 * Default is zero */


Please fix the indent.

Resolved and pushed patch (Commit : 9db1593)

tianjunwork · 2019-04-23T21:01:17Z

Docs/svt-hevc_encoder_user_guide.md

+| **vbvBufsize** | -vbv-bufsize | Any Number | 0 | VBV BufferSize in bits / second. Only used when RateControlMode is set to 1 |
+| **vbvBufInit** | -vbv-init | [0 - 100] | 90 | Sets how full the VBV buffer to be|
+| **hrdFlag** | -hrd | [0,1] | 0 | HRD Flag, 0 = OFF, 1 = ON |When hrdFlag is set to 1 it requires vbvMaxrate and vbvBufsize to be greater than 0 |
 | **MaxQpAllowed** | -max-qp | [0 - 51] | 48 | Maximum QP value allowed for rate control use. Only used when RateControlMode is set to 1. Has to be >= MinQpAllowed |


Could you also update sample.cfg? Thx.

Updated and pushed (Commit : 9db1593)

tianjunwork · 2019-04-23T21:04:09Z

README.md

-[![Travis Build Status](https://travis-ci.com/OpenVisualCloud/SVT-HEVC.svg?branch=master)](https://travis-ci.com/OpenVisualCloud/SVT-HEVC)
-[![Coverage Status](https://coveralls.io/repos/github/openvisualcloud/SVT-HEVC/badge.svg?branch=master)](https://coveralls.io/github/openvisualcloud/SVT-HEVC?branch=master)
+
+[![AppVeyor Build Status](https://ci.appveyor.com/api/projects/status/github/intel/SVT-HEVC?branch=master&svg=true)](https://ci.appveyor.com/project/intel/SVT-HEVC)


The left side openvisualcloud is the new one, please fix these.

Fixed and pushed patch (Commit : 9db1593)

tianjunwork · 2019-04-23T21:04:39Z

README.md

-   [svt-hevc-encoder-user-guide](Docs/svt-hevc_encoder_user_guide.md)
+
+-   [SVT-HEVC Encoder User Guide](Docs/svt-hevc_encoder_user_guide.md)
+


Please remove extra empty line.

Removed empty line and pushed patch (Commit : 9db1593)

tianjunwork · 2019-04-23T21:09:28Z

Source/Lib/Codec/EbEntropyCoding.c

        bitstreamPtr,
        scsPtr->staticConfig.fpsInVps == 1 ? EB_TRUE : EB_FALSE);
+    if (scsPtr->staticConfig.fpsInVps == 1)
+    {


Modified and pushed (Commit: 9db1593)

tianjunwork · 2019-04-23T21:11:29Z

Source/Lib/Codec/EbEntropyCoding.c

                    MIN_PU_SIZE,
                    &countNonZeroCoeffs);

+


please remove extra line

Modified and pushed (Commit: 9db1593)

tianjunwork · 2019-04-23T21:11:38Z

Source/Lib/Codec/EbEntropyCoding.c

                    MIN_PU_SIZE,
                    &countNonZeroCoeffs);

+


please remove extra line

Modified and pushed (Commit: 9db1593)

tianjunwork · 2019-04-23T21:12:39Z

Source/Lib/Codec/EbIntraPrediction.c

        switch(lumaMode) {

        case EB_INTRA_PLANAR:
+


please remove extra lines in this file

Modified and pushed (Commit: 9db1593)

tianjunwork · 2019-04-23T21:13:29Z

Source/Lib/Codec/EbPictureManagerProcess.c

 			   referenceEntryPtr->releaseEnable = EB_TRUE;
 			   referenceEntryPtr->referenceAvailable = EB_FALSE;
 			   referenceEntryPtr->isUsedAsReferenceFlag = pictureControlSetPtr->isUsedAsReferenceFlag;
+               referenceEntryPtr->feedbackArrived = EB_FALSE;


Please fix indent.

Modified and pushed (Commit: 9db1593)

-Updated code as per review comments as per coding guidelines, Indendation etc

tianjunwork · 2019-04-24T22:39:49Z

Source/Lib/Codec/EbEncHandle.c

    {
-        printf("Error Instance %u: hrdFlag must be [0 - 1]\n", channelNumber + 1);
+        printf("SVT [Error]: Instance %u: hrdFlag must be [0 - 1]\n", channelNumber + 1);
        return_error = EB_ErrorBadParameter;


please use "SVT_LOG("SVT [Error]:"

Please follow the coding style here.
if () {
}

Modified and pushed (Commit: 9db1593)

tianjunwork · 2019-04-24T22:39:58Z

Source/Lib/Codec/EbEncHandle.c

    if (config->hrdFlag == 1 && ((config->vbvBufsize <= 0) || (config->vbvMaxrate <= 0)))
    {
-        printf("Error instance %u: hrd requires vbv max rate and vbv bufsize to be greater than 0 ", channelNumber + 1);
+        printf("SVT [Error]: Instance %u: hrd requires vbv max rate and vbv bufsize to be greater than 0 ", channelNumber + 1);


please use "SVT_LOG("SVT [Error]:"

Modified and pushed (Commit: 9db1593)

tianjunwork · 2019-04-30T16:33:33Z

Source/App/EbAppConfig.c

+    { SINGLE_INPUT, USE_QP_FILE_TOKEN, "UseQpFile", SetCfgUseQpFile },
+    { SINGLE_INPUT, RATE_CONTROL_ENABLE_TOKEN, "RateControlMode", SetRateControlMode },
+    { SINGLE_INPUT, LOOK_AHEAD_DIST_TOKEN, "LookAheadDistance", SetLookAheadDistance},
+    { SINGLE_INPUT, TARGET_BIT_RATE_TOKEN, "TargetBitRate", SetTargetBitRate },


Please remove duplicated code here.

Removed Duplicate code, Commit : 5d0af0f

tianjunwork · 2019-04-30T16:39:08Z

Source/Lib/Codec/EbEncHandle.c

-
+    //Set required flags to signal vbv status when hrd is enabled
+    if (sequenceControlSetPtr->staticConfig.hrdFlag == 1) {
+		sequenceControlSetPtr->staticConfig.videoUsabilityInfo = 1;


Please fix the indent of your code changes in this file. Use space instead of tab.
Please review carefully the diff here, and fix all of them.

Modified code , Used space in place of tab, reviewed full EbEncHandle.c file, Commit : 5d0af0f

tianjunwork

Hi @dinesh0603 Sorry that I can't approve this commit. As you can see here, the indents are still messed up compared with original code.
Please also fix the indents in Source/API/EbApi.h. Read this file on github, you will know what is the difference. Please keep it same with original code.

tianjunwork · 2019-05-09T18:49:07Z

Source/App/EbAppConfig.c


    // Quantization
    { SINGLE_INPUT, QP_TOKEN, "QP", SetCfgQp },
+    { SINGLE_INPUT, USE_QP_FILE_TOKEN, "UseQpFile", SetCfgUseQpFile },


UseQpFile is duplicated. Pls clean up.

Removed duplicate code and pushed code (commit:67f68d8)

tianjunwork · 2019-05-09T18:56:57Z

Hi @dinesh0603, could you also provide some test commands or examples to demonstrate the usage of the new APIs?
How do they affect the output by setting the value for those APIs. The users may not be expert to encoder algorithm. Please help them to understand the usage.
You can either add in user guide appendix or add comment here.
Thank you.

…for coding guidelines

kelvinhu325 · 2019-05-20T06:34:40Z

@dinesh0603 , just tried to run vbv hrd(-hrd 1) test on my machine, but the generated bitstream gets crash for HM decoder, could you help take a look if there are errors on my cmdline? BTW, the same test with -hrd 0 works well.
cmdline is:
./SvtHevcEncApp -i ./Netflix_Boat_4096x2160_10bit_60Hz_P420.yuv -b Netflix_Boat_4096x2160_10bit_60Hz_P420_7_7500000.bin -w 4096 -h 2160 -bit-depth 10 -color-format 1 -encMode 7 -tune 0 -rc 1 -tbr 7500000 -vbv-maxrate 7500000 -vbv-bufsize 7500000 -hrd 1 -fps 60 -n 50 -nb 50
HM error info is:
HM software: Decoder Version [16.15] (including RExt)[Linux][GCC 5.4.0][64 bit]
TAppDecoderStaticd: /home/xxx/HM/build/linux/lib/TLibCommon/../../../../source/Lib/TLibCommon/TComBitStream.cpp:293: Void TComInputBitstream::read(UInt, UInt&): Assertion `m_fifo_idx + num_bytes_to_load < m_fifo.size()' failed.

SEIPeriod issues Signed-off-by: Hu, Kelvin <[email protected]>

Fixed hrd 1 crash issues caused by writeUvlc long bits, memmove and

Signed-off-by: kirithika <[email protected]>

…into vbv_dev # Conflicts: # Source/Lib/Codec/EbEncHandle.c # Source/Lib/Codec/EbEntropyCoding.c # Source/Lib/Codec/EbPacketizationProcess.c

This commit cleans up the unused variables in VBV code and add file changes that got missed out while resolving conflicts Signed-off-by: kirithika <[email protected]>

tianjunwork · 2019-07-20T00:00:02Z

Hi, @kirithika7, could you add a sign-off line to your commit msg? Thx.

bhavnahariMCW and others added 30 commits January 31, 2019 10:51

Add CLI support for vbv

808457f

Enable vbv for abr mode

de97249

Added VBV frame level support

488721b

1. Fixed Index comparision to compare with current Index + lookAheadD…

8f74ea2

…istance 2. Added Check for FrameIndex not exceding No of Frame to Encode

Enforce vbv buffer update to happen in decode order

8f3b2a4

Add new cli -hrd (default 0) + enable flags to signal hrd

f1e1a17

Add support for HRD SEI signalling

8c2f324

Add support for Active Parameter Set SEI

bfd35f2

Control VBV bufferFill access using mutex

38b744d

Add cli -vbv-init and remove hard-coded vbv buffer initialization

853a45e

If rate control is ON, base layer picture will not be processed until…

87f7729

… the feedback of the previous base layer has arrived. The impact on speed to be evaluated

VBV Code clean up and made VBV as function call

708bd26

Fix for the deadlock encoding frames fewer than 48

32dc411

Move vbv algorithm before using picture Qp for other RC context updates

88d1bef

Fix Warning: When NAL Unit is non-VCL NAL, TemporalId shall be greate…

f4d19b8

…r than or equal to the TemporalId of the access unit containing the NAL unit

Fix bug:The value of rbsp_stop_one_bit shall be equal to 1 in vps

cddec5a

Fix cbr signalling

96524c4

Fix Hrd Issue

a199b68

This fix ensures right signalling of Picture timing for keyframes>0

Fix uninitialized BPnumber value error when hrd is disabled

e692a04

Fix Hrd signalling for fixed GOP length

c8a7166

-Fix 1. encoded bitrate will be within target Bitrate limit 2. previo…

54eceb4

…usly It was going beyond target Bitrate and was within Max Bitrate, if Max rate is Greater than Target Bitrate

Add code to copy the pcs context into the Packetization Reorder Queue…

429edb5

… Entry

Add code to splice the bitstream and insert pic timing SEI

d857190

Fix bugs and cleanup

0d74be5

Refactor byte shifting code with memcpy+cleanup

22f80ea

Add support for strict cbr to prevent hrd buffer overflow

5f52a2f

Add code to consider filler bits for RC

dd24050

Merged Master to VBV-DEV branch

713643e

Merge branch 'master' tip into vbv_dev

6311c66

Update the filler bit error in the packetization feedback to rate con…

f268574

…trol

tianjunwork suggested changes Apr 23, 2019

View reviewed changes

- Updated Sample.cfg for added cli's and Readme

9db1593

-Updated code as per review comments as per coding guidelines, Indendation etc

tianjunwork reviewed Apr 24, 2019

View reviewed changes

dinesh0603 and others added 2 commits April 25, 2019 10:02

-Modified code as per review comments & coding guidelines

0caa1cc

Merge branch 'master' into vbv_dev

5f6db73

tianjunwork reviewed Apr 30, 2019

View reviewed changes

tianjunwork added the enhancement New feature or request label May 4, 2019

dinesh0603 and others added 3 commits May 8, 2019 15:28

-Modified code as per coding Guidelines

5d0af0f

Merge branch 'master' into vbv_dev

3ad1f46

Fix for Deadlock

f6482fd

tianjunwork suggested changes May 9, 2019

View reviewed changes

dinesh0603 added 2 commits May 13, 2019 15:46

-Modified code as per review comments and coding guidelines

67f68d8

-Removed Duplicate code (encMode) in EbAppConfig.c and Modified code …

742f9ca

…for coding guidelines

Hu, Kelvin and others added 2 commits June 11, 2019 18:02

Fixed hrd 1 crash issues caused by writeUvlc long bits, memmove and

a0bceeb

SEIPeriod issues Signed-off-by: Hu, Kelvin <[email protected]>

Merge pull request #1 from kelvin412/vbv_dev_crash

575a4b8

Fixed hrd 1 crash issues caused by writeUvlc long bits, memmove and

kirithika7 force-pushed the vbv_dev branch from e5ab0cf to 92b4fdb Compare July 19, 2019 10:48

kavithasampath and others added 2 commits July 19, 2019 16:30

Fix HRD initialization in packetization

0acc25b

Signed-off-by: kirithika <[email protected]>

Fix encoder crash with intra period 0

3b9a0fc

Signed-off-by: kirithika <[email protected]>

kirithika7 force-pushed the vbv_dev branch from 92b4fdb to 3b9a0fc Compare July 19, 2019 11:09

kirithika7 added 2 commits July 19, 2019 18:46

Merge branch 'master' of https://github.com/OpenVisualCloud/SVT-HEVC …

40bbea8

…into vbv_dev # Conflicts: # Source/Lib/Codec/EbEncHandle.c # Source/Lib/Codec/EbEntropyCoding.c # Source/Lib/Codec/EbPacketizationProcess.c

Cleanup

2f9c396

This commit cleans up the unused variables in VBV code and add file changes that got missed out while resolving conflicts Signed-off-by: kirithika <[email protected]>

kirithika7 force-pushed the vbv_dev branch from 4e0d597 to 2f9c396 Compare July 19, 2019 13:32

lijing0010 merged commit 041e35b into OpenVisualCloud:master Jul 22, 2019

hassount mentioned this pull request Jul 17, 2019

Add crf ratecontrol support #70

Open

Yeongjin-Jeong mentioned this pull request Aug 8, 2019

when encoding with codeVpsSpsPps enabled, encoded packets are not output #305

Closed

		- [svt-hevc-encoder-user-guide](Docs/svt-hevc_encoder_user_guide.md)

		- [SVT-HEVC Encoder User Guide](Docs/svt-hevc_encoder_user_guide.md)

Vbv dev #155

Vbv dev #155

Uh oh!

Conversation

dinesh0603 commented Mar 20, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tianjunwork Apr 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tianjunwork Apr 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tianjunwork left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tianjunwork commented May 9, 2019

Uh oh!

kelvinhu325 commented May 20, 2019

Uh oh!

tianjunwork Apr 30, 2019 •

edited

Loading

tianjunwork Apr 30, 2019 •

edited

Loading

tianjunwork left a comment •

edited

Loading