Skip to content

ram: allow a write request to be finished but not accepted by dram #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ljwljwljwljw merged 1 commit into from
Mar 3, 2021
Merged

ram: allow a write request to be finished but not accepted by dram #631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/test/csrc/ram.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,13 +350,15 @@ void dramsim3_helper_rising(const axi_channel &axi) {
void *data_start = meta->data + meta->offset * meta->size / sizeof(uint64_t);
axi_get_wdata(axi, data_start, meta->size);
meta->offset++;
// printf("accept a new write data\n");
}
if (wait_req_w) {
dramsim3_meta *meta = static_cast<dramsim3_meta *>(wait_req_w->meta);
// if this is the last beat
if (meta->offset == meta->len) {
assert(dram->will_accept(wait_req_w->address, true));
if (meta->offset == meta->len && dram->will_accept(wait_req_w->address, true)) {
dram->add_request(wait_req_w);
wait_req_w = NULL;
}
// printf("accept a new write data\n");
}
}

Expand Down Expand Up @@ -397,7 +399,11 @@ void dramsim3_helper_falling(axi_channel &axi) {

// WDATA: check whether the write data can be accepted
if (wait_req_w != NULL && dram->will_accept(wait_req_w->address, true)) {
axi_accept_wdata(axi);
dramsim3_meta *meta = static_cast<dramsim3_meta *>(wait_req_w->meta);
// we have to check whether the last finished write request has been accepted by dram
if (meta->offset != meta->len) {
axi_accept_wdata(axi);
}
}

// WRESP: if finished, we try the next write response
Expand Down