-
Notifications
You must be signed in to change notification settings - Fork 12.4k
Closed
Description
🎉 Description
- 🐛 This is a bug report.
- 📈 This is a feature request.
📝 Details
Ownable controls ownership of contract. I think RBACWithOwner is suitable to control access controll with permission than RBACWithAdmin. RBACWithAdmin has several problems.
- It can't be integrated with
Ownablebecuase both control permissions. If we have a contractT is RBACWithAdmin, Ownableand a singleadminadded, and want to chagneowner, 3 transaction are required
contract.transferOwnership(newOwner, {from: owner});
contract.adminAddRole(newOwner, 'admin', {from: owner});
contract.adminRemoveRole(owner, 'admin', {from: owner});RBACWithAdminmay have noadminat all ifadminsend trancation
contract.adminRemoveRole(admin, 'admin', {from: admin});I suggest to integrate Ownable with RBACWithAdmin to handle owner and ROLE_ADMIN at the same time, making sure that owner has all permission to control ROLE_ADMIN
Metadata
Metadata
Assignees
Labels
No labels