Conversation
|
do we use jshint at all, actually? I don't think we do, so we can delete .jshintrc |
|
LGTM after rebase @nventuro |
frangio
left a comment
frangio
left a comment
There was a problem hiding this comment.
I think the package-lock needs to be updated. Otherwise LGTM.
| import { ethGetBalance, ethSendTransaction } from './helpers/web3'; | ||
| const { ethGetBalance, ethSendTransaction } = require('./helpers/web3'); | ||
|
|
||
| var SecureTargetBounty = artifacts.require('SecureTargetBounty'); |
There was a problem hiding this comment.
Can we use const for these?
There was a problem hiding this comment.
Yes, but we're only removing Babel in this PR, that's coming on a separate one to keep everything tidy.
| } | ||
| } | ||
| }, | ||
| "babel-preset-env": { |
There was a problem hiding this comment.
This should've probably been removed, right? Re-run npm install?
There was a problem hiding this comment.
I looked into that as well, but they're dev dependencies of solidity-coverage, so they're in our package-lock
|
that would be nice, since I'm not a Node.js / web expert and currently scratching my head on trying to use the helper scripts for test but |
4 participants
We no longer use
import🎉Fixes #1062