Add an initial document for our code style #1141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-maiz
added
kind:improvement
documentation
4 tasks
nventuro
reviewed
Aug 1, 2018
CODE_STYLE.md
Outdated
| * Parameters must be prefixed with an underscore. | ||
|
|
||
| ``` | ||
| function test(_testParameter1, _testParameter2) { |
Contributor
There was a problem hiding this comment.
Parameters are missing their type.
Author
There was a problem hiding this comment.
🤔 thanks for catching it. I pushed the fix.
nventuro
approved these changes
Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run lint:all:fix).