Skip to content

Conversation

@frangio
Copy link
Contributor

@frangio frangio commented Aug 13, 2018

Travis jobs have been intermittently failing because of some issues on their side with sudo: required builds. This configuration line apparently means that the job will run in a virtual machine, as opposed to sudo: false which means the job will run in a container.

It doesn't look like we will need sudo, and the container-based run would be apparently slightly faster to boot. Let's see how this works.

(The first run is expected to be slower because it rebuilds the cache after a configuration change, IIRC.)

@frangio frangio added kind:improvement automation Tests and coverage running. Docsite publishing. labels Aug 13, 2018
Copy link
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it weird that their docs say this for sudo: true:

This has the advantage that no state persists between builds, offering a clean slate and making sure that your tests run in an environment built from scratch

, and this for sudo: false:

The container contents are a pristine copy of the Docker image, as guaranteed by Docker itself

Anyway, it seems either will suit us, and the build times seem to be similar, so I'll merge and we'll see how it goes over the next few days.

@nventuro nventuro merged commit f00fce5 into OpenZeppelin:master Aug 13, 2018
@frangio frangio deleted the travis-no-sudo branch August 13, 2018 20:32
@frangio frangio mentioned this pull request Aug 24, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation Tests and coverage running. Docsite publishing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants