Skip to content

Increase test coverage #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frangio merged 9 commits into from
Aug 24, 2018
Merged

Increase test coverage #1237

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
991d0ee
Fixed a SplitPayment test
nventuro Aug 24, 2018
1573086
Deleted unnecessary function.
nventuro Aug 24, 2018
22788d9
Improved PostDeliveryCrowdsale tests.
nventuro Aug 24, 2018
aeb5407
Improved RefundableCrowdsale tests.
nventuro Aug 24, 2018
ba02ab0
Improved MintedCrowdsale tests.
nventuro Aug 24, 2018
193a506
Improved IncreasingPriceCrowdsale tests.
nventuro Aug 24, 2018
12f4420
Fixed a CappedCrowdsale test.
nventuro Aug 24, 2018
5b0d148
Improved TimedCrowdsale tests.
nventuro Aug 24, 2018
33a6c5d
Improved descriptions of added tests.
nventuro Aug 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Deleted unnecessary function.
  • Loading branch information
@nventuro
nventuro committed Aug 24, 2018
commit 157308665480e09419a814f64a225860a4b32364
9 changes: 1 addition & 8 deletions contracts/ownership/Heritable.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ contract Heritable is Ownable {
* before the heir can take ownership.
*/
constructor(uint256 _heartbeatTimeout) public {
setHeartbeatTimeout(_heartbeatTimeout);
heartbeatTimeout_ = _heartbeatTimeout;
}

function setHeir(address _newHeir) public onlyOwner {
Expand Down Expand Up @@ -113,13 +113,6 @@ contract Heritable is Ownable {
timeOfDeath_ = 0;
}

function setHeartbeatTimeout(uint256 _newHeartbeatTimeout)
internal onlyOwner
{
require(ownerLives());
heartbeatTimeout_ = _newHeartbeatTimeout;
}

function ownerLives() internal view returns (bool) {
return timeOfDeath_ == 0;
}
Expand Down