Skip to content

Remove underscores from event parameters. #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frangio merged 3 commits into from
Sep 3, 2018
Merged

Remove underscores from event parameters. #1258

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdcd5fa
Remove underscores from event parameters.
Aug 30, 2018
f54d50d
Merge remote-tracking branch 'upstream/master' into elopio-refactor/1…
frangio Aug 31, 2018
eed7029
Add comment about ERC
Sep 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add comment about ERC
  • Loading branch information
Leo Arias committed Sep 3, 2018
commit eed70290dcf2088e69f9942baa8284987ed9cc3c
7 changes: 5 additions & 2 deletions CODE_STYLE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,11 @@ Any exception or additions specific to our project are documented below.
}
```

The exception are the parameters of events. There is not chance of ambiguity
with these, so they should not have underscores.
The exception are the parameters of events. There is no chance of ambiguity
with these, so they should not have underscores. Not even if they are
specified on an ERC with underscores; removing them doesn't change the ABI,
so we should be consistent with the rest of the events in this repository
and remove them.

* Internal and private state variables should have an underscore suffix.

Expand Down