Skip to content

Conversation

@frangio
Copy link
Contributor

@frangio frangio commented Sep 18, 2018

There is some unresolved design problems in #1333 which will probably need the interface to change.

@frangio frangio added this to the v2.0 milestone Sep 18, 2018
@frangio frangio requested a review from nventuro September 18, 2018 20:41
@frangio frangio added the breaking change Changes that break backwards compatibility of the public API. label Sep 18, 2018
@nventuro
Copy link
Contributor

You forgot to fix the imports in the mock contracts (SecureInvariantTargetMock and friends).

// See: https://github.com/ethereum/solidity/issues/4871
// solium-disable-next-line max-len
import {BreakInvariantBounty, Target} from "../../contracts/bounties/BreakInvariantBounty.sol";
import {BreakInvariantBounty, Target} from "../../contracts/drafts/BreakInvariantBounty.sol";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we changed this in #1319 and #1321, we may want to cherry-pick those commits in the rc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Changes that break backwards compatibility of the public API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants