Remove SignatureBouncer from drafts#1879
Merged
nventuro merged 4 commits intoOpenZeppelin:masterfrom Aug 16, 2019
Merged
Conversation
frangio
reviewed
Aug 12, 2019
Contributor
|
Hello, I actually recently made a PR for this file under #1875, but since it seems it is being removed, should I close the issue? Thanks, |
nventuro
force-pushed
the
rm-sig-bouncer
branch
from
19006ec to
1e3ceab
Compare
Contributor
Author
|
@Luiserebii yes, that is very unfortunate :( I'll be closing the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been in drafts forever with an unclear use case, and clashes with the naming of the GSN Bouncer contracts, specially the GSNBouncerSignature.