Skip to content

EnumerableSet improvements #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nventuro merged 3 commits into from
Feb 4, 2020
Merged

EnumerableSet improvements #2077

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6465a1
Remove newAddressSet
nventuro Feb 4, 2020
292723e
Add count and get functions.
nventuro Feb 4, 2020
cb77498
Fix lint
nventuro Feb 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove newAddressSet
  • Loading branch information
@nventuro
nventuro committed Feb 4, 2020
commit f6465a16c7f07d93fd3834965aa5b2ba4919a40d
4 changes: 0 additions & 4 deletions contracts/mocks/EnumerableSetMock.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ contract EnumerableSetMock{

EnumerableSet.AddressSet private set;

constructor() public {
set = EnumerableSet.newAddressSet();
}

function contains(address value) public view returns (bool) {
return set.contains(value);
}
Expand Down
11 changes: 0 additions & 11 deletions contracts/utils/EnumerableSet.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,6 @@ library EnumerableSet {
address[] values;
}

/**
* @dev Creates a new empty address set.
*/
function newAddressSet()
internal
pure
returns (AddressSet memory)
{
return AddressSet({values: new address[](0)});
}

/**
* @dev Add a value to a set. O(1).
* Returns false if the value was already in the set.
Expand Down