Shareable: improved code to styling conventions, added functionality todo with owners #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 3, 2017 20:39
…ugly parameters from the contract constructor function.
Contributor
|
Thanks @RFVenter! We have been thinking about refactoring the Shareable contract. I have a couple questions. Shareable is used in other parts of OpenZeppelin (only MultisigWallet for now) and these changes are breaking those uses. In particular the change in the constructor. I think in practice a Shareable contract always has a set of many owners, even at construction time, which is why they were constructor parameters. What did you consider ugly about them? Have you thought about using a dynamic array to hold the owners? |
Author
|
Hi @frangio. Good job for a very diplomatic response 👍 Please excuse my crude comments (from before).
|
…st ETH sent to 'old' contracts. In practice any public Ethereum address is a target to receiving ETH. Often ETH will find its way to a Contract via send (not via a function call), even though the contract was not meant to receive ETH. For this reason all contracts should have a withdrawEther function, even after a contract is meant to retire. For this reason no contract should really ever selfdestruct, instead always only having the withdrawEther function active and disabling all other functions.
Contributor
|
@RFVenter can you please check broken tests? |
Contributor
|
Closed since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.