-
Notifications
You must be signed in to change notification settings - Fork 12.4k
Merkle proof library with tests and docs #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3c4d0d0
MerkleProof library and initial stubbed out tests
yondonfu 2e0bd06
Add tests, docs and MerkleTree helper
yondonfu 30e2023
Fix indentation in MerkleProof.sol and remove mock contract
yondonfu bc3db5d
Fix weird indent issue for inline assembly
yondonfu 863ad48
Check proof length multiple of 32. Use keccak256 instead of sha3
yondonfu 24323d3
MerkleTree util class hashes elements
yondonfu bcda5bf
Merge branch 'master' into feature/merkleproof
yondonfu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix indentation in MerkleProof.sol and remove mock contract
- Loading branch information
commit 30e202313d9c4f6bacac64b5a634f312424a7be7
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comparing this implementation to https://github.com/raiden-network/raiden/blob/master/raiden/smart_contracts/NettingChannelLibrary.sol#L268, it seems the only difference is whether to hash the
leafelement before entering the loop.I guess the difference is on how you build the tree: is it the tree who hashes every element initially to form the leaves, or should the tree's user do it (as is the case here)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense for
_leafto be the hash of the leaf element instead of the actual leaf element since it avoids an additionalkeccak256operation on-chain - the more logic that can be pushed off-chain the better imo. Then, the comments/documentation can make it clearer that_leafshould be the hash of the leaf element and not the actual leaf element.