Merged
Conversation
frangio
reviewed
Jun 8, 2021
Contributor
frangio
left a comment
frangio
left a comment
There was a problem hiding this comment.
Code and tests look good to me.
frangio
previously approved these changes
Jun 10, 2021
Contributor
frangio
left a comment
frangio
left a comment
There was a problem hiding this comment.
Looks good, though I wonder if we also want a set(BitMap, uint256, bool) function. Could be useful in some cases.
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
frangio
approved these changes
Jun 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native bitmap are really storage inneficient:
mapping(X => bool)will use a new storage slot for each entrybool[]will use an underlyingbytes1[]array, which only truly uses 32 bits per 256 bits storage slot.This PR include a dense bitmap, that will save on gas when entries are consecutive. This design is used by Uniswap merkle-distributor to reduce the gas cost of writing to new (clean) storage slot by a factor 8 over what bool[] would have required.
PR Checklist