Use private variable instead of immutable to allow calls to _msgSender in constructor.#2754
Merged
frangio merged 2 commits intoOpenZeppelin:masterfrom Jul 6, 2021
Merged
Conversation
frangio
approved these changes
Jul 6, 2021
|
Sorry, but I think this solution is sub-optimal, compared to the solution in https://github.com/OpenZeppelin/openzeppelin-contracts/pull/2739/files
|
Contributor
|
@drortirosh Thanks for the feedback. The reasons why we went with this change instead are:
Additionally, the Solidity team has hinted that this limitation could soon be lifted at the compiler level, and we plan to add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Immutable _trustedForwarder causes issues when _msgSender() is called in constructors
Fixes #2739
PR Checklist