Delay the Pending state until strictly after proposal.voteStart#2892
Merged
frangio merged 10 commits intoOpenZeppelin:masterfrom Oct 6, 2021
Merged
Delay the Pending state until strictly after proposal.voteStart#2892frangio merged 10 commits intoOpenZeppelin:masterfrom
frangio merged 10 commits intoOpenZeppelin:masterfrom
Conversation
issue with potential invalid implementations of the voting token
frangio
reviewed
Oct 4, 2021
Contributor
|
Missing a changelog entry. "Delayed Governor vote start and end by one block"? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delay the Pending state until strictly after proposal.voteStart to avoid issue with potential invalid implementations of the voting token
Fixes #2886
PR Checklist