fix testing error throwing #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
requested changes
Jul 22, 2017
Contributor
frangio
left a comment
frangio
left a comment
There was a problem hiding this comment.
Great idea! Thanks!
Using return for control flow in this way seems like it could cause some headaches in the future. Could you change these tests to use the following equivalent pattern?
try {
await doSomething();
assert.fail('should have thrown');
} catch (e) {
assertJump(e);
/* extra validations here */
}
Contributor
Author
|
Thx @frangio for the suggestion. I agree it seems to be a better design. I've refactored other occurrences of returning in |
frangio
approved these changes
Jul 22, 2017
ProphetDaniel
pushed a commit
to classicdelta/Smart-Contracts
that referenced
this pull request
Mar 9, 2018
fix testing error throwing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After spotting a problem with checking if a contract correctly throws an error in tests as explained in #323 , I've decided to find similar cases in the codebase and fix them all.