Skip to content

feat: add 1363 implementation #3487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vittominacori wants to merge 3 commits into from
Closed

feat: add 1363 implementation #3487

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2515aea
feat: add ERC1363 contracts
vittominacori Jun 16, 2022
df2001d
feat: add tests
vittominacori Jun 16, 2022
1d33ecf
fix: adjust return value check
vittominacori Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: adjust return value check
  • Loading branch information
@vittominacori
vittominacori committed Jun 17, 2022
commit 1d33ecface81929b0de4485426316dfd62274df6
4 changes: 2 additions & 2 deletions contracts/token/ERC1363/ERC1363.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ abstract contract ERC1363 is ERC20, IERC1363, ERC165 {
return false;
}
bytes4 retval = IERC1363Receiver(recipient).onTransferReceived(_msgSender(), sender, amount, data);
return (retval == IERC1363Receiver(recipient).onTransferReceived.selector);
return retval == IERC1363Receiver.onTransferReceived.selector;
}

/**
Expand All @@ -127,6 +127,6 @@ abstract contract ERC1363 is ERC20, IERC1363, ERC165 {
return false;
}
bytes4 retval = IERC1363Spender(spender).onApprovalReceived(_msgSender(), amount, data);
return (retval == IERC1363Spender(spender).onApprovalReceived.selector);
return retval == IERC1363Spender.onApprovalReceived.selector;
}
}