Skip to content

Remove token.finishMinting() from default finalization #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frangio merged 2 commits into from
Aug 14, 2017
Merged

Remove token.finishMinting() from default finalization #364

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fc6bb7
remove token.finishMinting() from default finalization
frangio Aug 13, 2017
3645213
add test for finishMinting
frangio Aug 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add test for finishMinting
  • Loading branch information
@frangio
frangio committed Aug 14, 2017
commit 36452136f1ef26ecfeed3fa07404e3ec113c4489
8 changes: 7 additions & 1 deletion test/MintableToken.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

const assertJump = require('./helpers/assertJump');
import expectThrow from './helpers/expectThrow';
var MintableToken = artifacts.require('../contracts/Tokens/MintableToken.sol');

contract('Mintable', function(accounts) {
Expand Down Expand Up @@ -37,4 +37,10 @@ contract('Mintable', function(accounts) {
assert(totalSupply, 100);
})

it('should fail to mint after call to finishMinting', async function () {
await token.finishMinting();
assert.equal(await token.mintingFinished(), true);
await expectThrow(token.mint(accounts[0], 100));
})

});