Add comments to unsafeAccess functions of Arrays library
#3718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hello @tinchoabbate and thank you for this PR. I'm wondering if we should link to 0.8.17 or to the latest version @frangio any opinion ? |
Contributor
Author
|
I usually prefer linking to a specific version, because that's exactly what I read while reviewing the contract, and I know the content linked won't change. |
Contributor
|
Agree with using a link to a fixed version. |
JulissaDantes
pushed a commit
to JulissaDantes/openzeppelin-contracts
that referenced
this pull request
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3589 introduced new
unsafeAccessfunctions in theArrayslibrary to read dynamic arrays data skipping Solidity's safety checks.This PR adds some comments to explain the purpose of the assembly in those functions.