Feature - Token wallet #378
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This is a pretty cool idea @JGcarv! What was the rationale for adding the |
Contributor
Author
|
I added the name feature because at the time I was thinking of a more user
facing application, and therefore, using names is more friendly than
addresses. But, it's definitely not necessary.
Another thing, I also intended to make it ERC223 compatible, but that's
still is a ongoing discussion, so I decided to leave it for now.
…On sáb, 19 de ago de 2017 18:17 Francisco Giordano ***@***.***> wrote:
This is a pretty cool idea @JGcarv <https://github.com/jgcarv>!
What was the rationale for adding the tokenName functions?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#378 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APX3CxVGOG7szNorvE0k_3cndxLYbxffks5sZ1DjgaJpZM4O6xy9>
.
|
Contributor
|
Yeah, I think the user- friendly names should be resolved elsewhere, e.g. by using ENS or at the application level. |
JGcarv
force-pushed
the
feature/tokenWallet
branch
from
27755c8 to
13f0fe4
Compare
Contributor
Author
|
Agreed! Just removed the functions that used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple base contract that allows child contracts to handle tokens.
It can be used for contracts that expect to receive any token(wallets, vaults, exchanges, etc) and as a safe measure to avoid locking tokens in a unprepared contract.