Skip to content

Remove Address.isContract #3945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frangio merged 20 commits into from
Jan 24, 2023
Merged

Remove Address.isContract #3945

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
acd97fd
Remove isContract
JulissaDantes Jan 11, 2023
a87bd43
improve format
JulissaDantes Jan 11, 2023
81667ae
bump pragma
JulissaDantes Jan 11, 2023
26863ed
add CHANGELOG entry
JulissaDantes Jan 11, 2023
8ad9f9f
run lint
JulissaDantes Jan 11, 2023
df7ff46
Update contracts/token/ERC777/ERC777.sol
JulissaDantes Jan 12, 2023
aa1a158
Update contracts/token/ERC721/extensions/ERC721Consecutive.sol
JulissaDantes Jan 12, 2023
3e9c380
Update contracts/proxy/utils/Initializable.sol
JulissaDantes Jan 12, 2023
c484d04
add documentation
JulissaDantes Jan 12, 2023
0fb4423
Update nav
JulissaDantes Jan 12, 2023
23b8f57
Update documentation
JulissaDantes Jan 16, 2023
95799e9
Resolve conflicts
JulissaDantes Jan 16, 2023
7981474
Update faq.adoc
JulissaDantes Jan 23, 2023
ba6ca20
Update docs/modules/ROOT/pages/faq.adoc
JulissaDantes Jan 24, 2023
300f4ff
Create changeset
JulissaDantes Jan 24, 2023
f8d0f40
fix changeset package name
frangio Jan 24, 2023
46d68bf
remove from changelog since there is a changeset
frangio Jan 24, 2023
e697766
remove pr link from changeset
frangio Jan 24, 2023
33b55af
add faq titles
frangio Jan 24, 2023
91802e5
tweak wording
frangio Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update docs/modules/ROOT/pages/faq.adoc 
Co-authored-by: Hadrien Croubois <[email protected]>
  • Loading branch information
@JulissaDantes @Amxx
JulissaDantes and Amxx authored Jan 24, 2023
commit ba6ca2093f01403672d52b77efa266945abf81bc
2 changes: 1 addition & 1 deletion docs/modules/ROOT/pages/faq.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Can I restrict a function to EOAs only?

When calling external addresses from your contract it is unsafe to assume that an address is an externally-owned account (EOA) and not a contract. Preventing calls from contracts is highly discouraged. It breaks composability, breaks support for smart wallets like Gnosis Safe, and does not provide security since it can be circumvented by calling from a contract constructor.

Although checking that the address has code, `address.code.length > 0`, may seem to differentiate contracts from EOAs, it can only say that an address is currently a contract, and its negation (that an address is not currently a contract) does not imply that the address is an EOA.Some counterexamples are:
Although checking that the address has code, `address.code.length > 0`, may seem to differentiate contracts from EOAs, it can only say that an address is currently a contract, and its negation (that an address is not currently a contract) does not imply that the address is an EOA. Some counterexamples are:

- a contract in construction address
- an address where a contract will be created
Expand Down