Skip to content

Add ERC1155.totalSupply that returns overall supply count #3962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amxx merged 18 commits into from
Jan 25, 2023
Merged

Add ERC1155.totalSupply that returns overall supply count #3962

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
139363f
Fix wrong PR `CHANGELOG` link (#3957)
pcaversaccio Jan 13, 2023
3902514
update contract
JulissaDantes Jan 16, 2023
7a267c7
add tests for the new function
JulissaDantes Jan 16, 2023
17de1d9
add changelog entry
JulissaDantes Jan 16, 2023
3776289
update tests format
JulissaDantes Jan 16, 2023
154605d
Add test case
JulissaDantes Jan 17, 2023
4dae02c
update changelog
JulissaDantes Jan 17, 2023
a27ba26
update changelog
JulissaDantes Jan 17, 2023
58b21c2
move to breaking changes in the changelog
JulissaDantes Jan 18, 2023
a634d58
add reason to unchecked code
JulissaDantes Jan 18, 2023
d511fa6
clean up whitespace
frangio Jan 20, 2023
7be1534
Update test/token/ERC1155/extensions/ERC1155Supply.test.js
JulissaDantes Jan 23, 2023
e143fae
add expect of totalSupply(uint256)
frangio Jan 24, 2023
737d014
improve unchecked overflow comments
frangio Jan 24, 2023
73382df
remove .only
frangio Jan 24, 2023
7c88b4c
Merge branch 'next-v5.0' into erc1155-totalSupply
JulissaDantes Jan 25, 2023
493c12d
Update changelog
JulissaDantes Jan 25, 2023
2ddaded
Add changeset
JulissaDantes Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove .only
  • Loading branch information
@frangio
frangio committed Jan 24, 2023
commit 73382dfe9646c3477e562bb9013bbff4810e3467
2 changes: 1 addition & 1 deletion test/token/ERC1155/extensions/ERC1155Supply.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ contract('ERC1155Supply', function (accounts) {
});
});

context.only('other', function () {
context('other', function () {
it('supply unaffected by no-op', async function () {
this.token.safeTransferFrom(ZERO_ADDRESS, ZERO_ADDRESS, firstTokenId, firstTokenAmount, '0x', {
from: ZERO_ADDRESS,
Expand Down