Create ProposalSalt event for TimelockController#4001
Merged
frangio merged 11 commits intoOpenZeppelin:masterfrom Jan 27, 2023
Merged
Create ProposalSalt event for TimelockController#4001frangio merged 11 commits intoOpenZeppelin:masterfrom
frangio merged 11 commits intoOpenZeppelin:masterfrom
Conversation
🦋 Changeset detectedLatest commit: f4b444b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Amxx
reviewed
Jan 25, 2023
Amxx
reviewed
Jan 25, 2023
frangio
requested changes
Jan 26, 2023
Co-authored-by: Francisco <frangio.1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3216
Fixes LIB-639
When scheduling a transaction using the TimelockController, one is required to provide a salt to distinguish otherwise identical transactions. The salt parameter is not emitted in the CallScheduled event which makes it impossible to recover. This PR introduces the
ProposalSaltevent to get the salt after scheduling an operation, if salt == 0 it will not emit an event.PR Checklist
npx changeset add)