Skip to content

Add GUIDELINES.md for marking abstract contracts #4010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frangio merged 4 commits into from
Jun 14, 2023
Merged

Add GUIDELINES.md for marking abstract contracts #4010

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f296f8c
Add guidelines for marking `abstract` contracts
ernestognw Jan 28, 2023
5c179cf
Merge branch 'master' into add-abstract-guidelines
Amxx Jun 14, 2023
3f8d6ec
mark contracts as abstracts
Amxx Jun 14, 2023
b0c5d1e
fix tests
frangio Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix tests
  • Loading branch information
@frangio
frangio committed Jun 14, 2023
commit b0c5d1e476e1d6c8a3eaa11b17c01ff5824d5950
2 changes: 1 addition & 1 deletion test/token/ERC1155/utils/ERC1155Holder.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const { BN } = require('@openzeppelin/test-helpers');

const ERC1155Holder = artifacts.require('ERC1155Holder');
const ERC1155Holder = artifacts.require('$ERC1155Holder');
const ERC1155 = artifacts.require('$ERC1155');

const { expect } = require('chai');
Expand Down
2 changes: 1 addition & 1 deletion test/token/ERC721/utils/ERC721Holder.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const { expect } = require('chai');

const ERC721Holder = artifacts.require('ERC721Holder');
const ERC721Holder = artifacts.require('$ERC721Holder');
const ERC721 = artifacts.require('$ERC721');

contract('ERC721Holder', function (accounts) {
Expand Down