Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add SafeERC20 tests for succeeding operations
  • Loading branch information
frangio committed Aug 28, 2017
commit c37c233d22ccab2e599cb6ccbc25e1e11710994f
11 changes: 11 additions & 0 deletions test/SafeERC20.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,15 @@ contract('SafeERC20', function () {
await this.helper.doFailingApprove().should.be.rejectedWith(EVMThrow);
});

it('should not throw on succeeding transfer', async function () {
await this.helper.doSucceedingTransfer().should.be.fulfilled;
});

it('should not throw on succeeding transferFrom', async function () {
await this.helper.doSucceedingTransferFrom().should.be.fulfilled;
});

it('should not throw on succeeding approve', async function () {
await this.helper.doSucceedingApprove().should.be.fulfilled;
});
});
46 changes: 41 additions & 5 deletions test/helpers/SafeERC20Helper.sol
Original file line number Diff line number Diff line change
Expand Up @@ -25,24 +25,60 @@ contract ERC20FailingMock is ERC20 {
}
}

contract ERC20SucceedingMock is ERC20 {
function transfer(address, uint256) returns (bool) {
return true;
}

function transferFrom(address, address, uint256) returns (bool) {
return true;
}

function approve(address, uint256) returns (bool) {
return true;
}

function balanceOf(address) constant returns (uint256) {
return 0;
}

function allowance(address, address) constant returns (uint256) {
return 0;
}
}

contract SafeERC20Helper {
using SafeERC20 for ERC20;

ERC20 token;
ERC20 failing;
ERC20 succeeding;

function SafeERC20Helper() {
token = new ERC20FailingMock();
failing = new ERC20FailingMock();
succeeding = new ERC20SucceedingMock();
}

function doFailingTransfer() {
token.safeTransfer(0, 0);
failing.safeTransfer(0, 0);
}

function doFailingTransferFrom() {
token.safeTransferFrom(0, 0, 0);
failing.safeTransferFrom(0, 0, 0);
}

function doFailingApprove() {
token.safeApprove(0, 0);
failing.safeApprove(0, 0);
}

function doSucceedingTransfer() {
succeeding.safeTransfer(0, 0);
}

function doSucceedingTransferFrom() {
succeeding.safeTransferFrom(0, 0, 0);
}

function doSucceedingApprove() {
succeeding.safeApprove(0, 0);
}
}