Skip to content

Nextv5.0 checkpoint history removal #4170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RenanSouza2 wants to merge 13 commits into from
Closed

Nextv5.0 checkpoint history removal #4170

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
62894b1
mid commit
RenanSouza2 Apr 8, 2023
3b8610f
proposal 1
RenanSouza2 Apr 8, 2023
578bc8b
Checkpoint tests some fixes
RenanSouza2 Apr 15, 2023
d53e29d
returns zero as past value
RenanSouza2 Apr 15, 2023
d89cf69
more tests
RenanSouza2 Apr 15, 2023
83f4f64
Votes
RenanSouza2 Apr 15, 2023
bf22828
ERC20Votes
RenanSouza2 Apr 15, 2023
9b13eb3
ERC20VotesComp
RenanSouza2 Apr 15, 2023
a91837c
Tested
RenanSouza2 Apr 15, 2023
73ce437
compiled
RenanSouza2 Apr 16, 2023
8b9029b
lint
RenanSouza2 Apr 16, 2023
16ae23b
some fixes
RenanSouza2 Apr 17, 2023
da3ac53
enable tests
RenanSouza2 Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
more tests
  • Loading branch information
@RenanSouza2
RenanSouza2 committed Apr 15, 2023
commit d89cf696e9e29b847a2625f8d7248878ef8daa40
46 changes: 10 additions & 36 deletions test/utils/Checkpoints.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ contract('Checkpoints', function () {
self.methods['$latestCheckpoint_Checkpoints_Trace224(uint256)'](0, ...args);
const push = (self, ...args) => self.methods['$push(uint256,uint256)'](0, ...args);
const getAtBlock = (self, ...args) => self.methods['$upperLookup(uint256,uint32)'](0, ...args);
const getAtRecentBlock = (self, ...args) => self.methods['$getAtProbablyRecentBlock(uint256,uint256)'](0, ...args);
const getLength = (self, ...args) => self.methods['$length_Checkpoints_Trace224(uint256)'](0, ...args);

describe('without checkpoints', function () {
Expand Down Expand Up @@ -58,30 +57,17 @@ contract('Checkpoints', function () {
expect(ckpt[2]).to.be.bignumber.equal(web3.utils.toBN('3'));
});

for (const getAtBlockVariant of [getAtBlock, getAtRecentBlock]) {
describe(`lookup: ${getAtBlockVariant}`, function () {
it('returns past values', async function () {
expect(await getAtBlockVariant(this.mock, this.tx1.receipt.blockNumber - 1)).to.be.bignumber.equal('0');
expect(await getAtBlockVariant(this.mock, this.tx1.receipt.blockNumber)).to.be.bignumber.equal('1');
expect(await getAtBlockVariant(this.mock, this.tx2.receipt.blockNumber)).to.be.bignumber.equal('2');
// Block with no new checkpoints
expect(await getAtBlockVariant(this.mock, this.tx2.receipt.blockNumber + 1)).to.be.bignumber.equal('2');
expect(await getAtBlockVariant(this.mock, this.tx3.receipt.blockNumber)).to.be.bignumber.equal('3');
expect(await getAtBlockVariant(this.mock, this.tx3.receipt.blockNumber + 1)).to.be.bignumber.equal('3');
});
it('reverts if block number >= current block', async function () {
await expectRevert(
getAtBlockVariant(this.mock, await web3.eth.getBlockNumber()),
'Checkpoints: block not yet mined',
);

await expectRevert(
getAtBlockVariant(this.mock, (await web3.eth.getBlockNumber()) + 1),
'Checkpoints: block not yet mined',
);
});
describe(`lookup: getAtBlock`, function () {
it('returns past values', async function () {
expect(await getAtBlock(this.mock, this.tx1.receipt.blockNumber - 1)).to.be.bignumber.equal('0');
expect(await getAtBlock(this.mock, this.tx1.receipt.blockNumber)).to.be.bignumber.equal('1');
expect(await getAtBlock(this.mock, this.tx2.receipt.blockNumber)).to.be.bignumber.equal('2');
// Block with no new checkpoints
expect(await getAtBlock(this.mock, this.tx2.receipt.blockNumber + 1)).to.be.bignumber.equal('2');
expect(await getAtBlock(this.mock, this.tx3.receipt.blockNumber)).to.be.bignumber.equal('3');
expect(await getAtBlock(this.mock, this.tx3.receipt.blockNumber + 1)).to.be.bignumber.equal('3');
});
}
});

it('multiple checkpoints in the same block', async function () {
const lengthBefore = await getLength(this.mock);
Expand All @@ -95,18 +81,6 @@ contract('Checkpoints', function () {
expect(await getLength(this.mock)).to.be.bignumber.equal(lengthBefore.addn(1));
expect(await latest(this.mock)).to.be.bignumber.equal('10');
});

it('more than 5 checkpoints', async function () {
for (let i = 4; i <= 6; i++) {
await push(this.mock, i);
}
expect(await getLength(this.mock)).to.be.bignumber.equal('6');
const block = await web3.eth.getBlockNumber();
// recent
expect(await getAtRecentBlock(this.mock, block - 1)).to.be.bignumber.equal('5');
// non-recent
expect(await getAtRecentBlock(this.mock, block - 9)).to.be.bignumber.equal('0');
});
});
});

Expand Down